Suppress hash() clang integer sanitizer issues #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sanitizer-ci #667 +/- ##
===============================================
Coverage ? 92.19%
===============================================
Files ? 2
Lines ? 2127
Branches ? 0
===============================================
Hits ? 1961
Misses ? 166
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Saalvage
force-pushed
the
clang-integer-sanitizer
branch
from
f068a77 to
350458e
Compare
|
I'm very sorry for the incredibly late response to this very straightforward PR. I've decided to add various CI sanitizers in order to prevent similar situations like this in the future! Thank you very much for your contribution! |
Saalvage
force-pushed
the
clang-integer-sanitizer
branch
from
350458e to
3588f71
Compare
onqtam
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add sanitizer CI * Fix setup * Separate sanatizers * Add integer sanitizers * Finalize sanitizer list * Specify libc++ * Remove overly complicated sanitizers * Readd removed CI * Suppress hash() clang integer sanitizer issues * Add changes to parts * Add version limit Co-authored-by: Stefan <29021710+Saalvage@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash() functions added in the latest v2.4.9 release trigger clang integer sanitizer issues. Since the integer behavior in these functions is intentional, this change suppresses the sanitizer issues.