This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Windows: Support for stats (docker #25737) #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowenna
force-pushed
the
jjh/engine-api
branch
4 times, most recently
from
cefa4ba to
9791b9f
Compare
|
ping @docker/core-engine-api-maintainers |
| @@ -113,7 +113,8 @@ func imageBuildOptionsToQuery(options types.ImageBuildOptions) (url.Values, erro | |||
| return query, nil | |||
| } | |||
|
|
|||
| func getDockerOS(serverHeader string) string { | |||
| // GetDockerOS returns the operating system based on the server header from the daemon. | |||
| func GetDockerOS(serverHeader string) string { | |||
There was a problem hiding this comment.
We might want to move this function out of this file but that can be done in a follow-up PR 😉
There was a problem hiding this comment.
Yup, make sense. I'll make sure to do that as a follow-up.
|
LGTM 🐮 |
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/engine-api
branch
from
9791b9f to
0ddf513
Compare
|
The matching docker PR moby/moby#25737 is all green 💚 now and just waiting for this to be merged so it can be rebased. |
|
Closing now engine-api is back in docker. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Adds support for docker stats on Windows. See moby/moby#25737 for detailed information.