Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manuals: add page on deprecated and retired features #21838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Jan 16, 2025

Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for docsdocker failed. Why did it fail? →

Name Link
🔨 Latest commit 5322640
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/678a4ed5e2ebe800079b7ccf

@dvdksn dvdksn force-pushed the sunset-products branch 2 times, most recently from dca4ce6 to 6c37bd0 Compare January 16, 2025 13:54
@dvdksn dvdksn marked this pull request as ready for review January 16, 2025 14:14
@dvdksn dvdksn requested review from justincormack, sflondonla and a team January 16, 2025 14:14
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little nits, but otherwise I really like this approach. one page for deprecated/retired features is much easier to find and digest

Docker Toolbox was used on older systems where Docker Desktop could not run. It
bundled Docker Machine, Docker Engine, and Docker Compose into a single
installer. Toolbox is no longer maintained and is effectively replaced by
Docker Desktop on current systems. References to Docker Toolbox occasionally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to DD

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>

> [!NOTE]
> For information about enterprise-level features offered by Docker today,
> see the [Docker Business subscription](/subscription/details.md#docker-business).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usha-mandya @dvdksn this is what is causing the build error. I tested it locally and if I add /manuals to the front of subscription it fixes it.

suggestion to update link to: manuals/subscription/details.md#docker-business

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants