-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-stage builds to the C++ guide #21562
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We're using the same sample repository that you used in the previous sections of this guide. If you haven't already cloned the repository, clone it now: | ||
|
||
```bash | ||
$ git clone https://github.com/dockersamples/c-plus-plus-docker.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo should be synced with the upstream repo created by Pradumna.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be a completely separate page. I think it could be a section on the first page: https://docs.docker.com/guides/cpp/containerize/#run-the-application
The sequence could be:
- Get the repo
- Run the app
- Make it multi-stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that Pradumna's example is a bit complicated to make multi-stage. If I want to do it on the same page, I have to use my own example for the whole thing. Would that be OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerabi hi, yea that's fine - multi-stage is such an important strategy, especially for compiled programs, that I think it makes sense to present that as the main workflow.
Description
Having a multi-stage build is an essential thing to learn for containerizing a compiled language.
Related issues or tickets
N/A
Reviews