Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-stage builds to the C++ guide #21562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aerabi
Copy link

@aerabi aerabi commented Dec 4, 2024

Description

Having a multi-stage build is an essential thing to learn for containerizing a compiled language.

Related issues or tickets

N/A

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 3d8e01f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6750613a2b471c00075abe3a
😎 Deploy Preview https://deploy-preview-21562--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

We're using the same sample repository that you used in the previous sections of this guide. If you haven't already cloned the repository, clone it now:

```bash
$ git clone https://github.com/dockersamples/c-plus-plus-docker.git
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo should be synced with the upstream repo created by Pradumna.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be a completely separate page. I think it could be a section on the first page: https://docs.docker.com/guides/cpp/containerize/#run-the-application

The sequence could be:

  1. Get the repo
  2. Run the app
  3. Make it multi-stage

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that Pradumna's example is a bit complicated to make multi-stage. If I want to do it on the same page, I have to use my own example for the whole thing. Would that be OK?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerabi hi, yea that's fine - multi-stage is such an important strategy, especially for compiled programs, that I think it makes sense to present that as the main workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants