Add support for volume Subpath option #11597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally update some workflows in CI to add Moby v26 RC2 to the matrix and upgrade the various Docker actions. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11597 +/- ##
==========================================
- Coverage 58.20% 58.15% -0.05%
==========================================
Files 135 135
Lines 11611 11612 +1
==========================================
- Hits 6758 6753 -5
- Misses 4182 4186 +4
- Partials 671 673 +2 ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Mar 13, 2024
| @@ -144,8 +141,9 @@ jobs: | |||
| - plugin | |||
| - standalone | |||
| engine: | |||
| - 26.0.0-rc2 | |||
There was a problem hiding this comment.
👍 we indeed should have tests ran with RC release before those get public
|
please rebase so we can merge |
|
We still need #11583 to be merged first |
|
I cherry-picked required changes into #11652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allows to use moby/moby#45687 in compose
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did