Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass services list to projectOrName function to add profiles for targeted services #10025

Merged
merged 5 commits into from
Nov 30, 2022
Merged

pass services list to projectOrName function to add profiles for targeted services #10025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23715c8
pass services list to projectOrName function to add profiles for targ…
glours Nov 28, 2022
933173a
add e2e tests using explicitly profiles
glours Nov 30, 2022
3ebb6da
add e2e tests to check no profile usages
glours Nov 30, 2022
fb63b46
add e2e tests to check profile activation via targeted service
glours Nov 30, 2022
a4b2285
add file header and cleanup profiles e2e tests
glours Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add e2e tests using explicitly profiles 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
  • Loading branch information
@glours
glours committed Nov 30, 2022
commit 933173a6378512176e79da5d77e8564875383963
8 changes: 8 additions & 0 deletions pkg/e2e/fixtures/profiles/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
services:
main:
image: nginx:alpine

profiled-service:
image: nginx:alpine
profiles:
- test-profile
59 changes: 59 additions & 0 deletions pkg/e2e/profiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
package e2e

import (
"gotest.tools/v3/assert"
"gotest.tools/v3/icmd"
"strings"
"testing"
)

func TestExplicitProfileUsage(t *testing.T) {
c := NewParallelCLI(t)
const projectName = "compose-e2e-profiles"
const profileName = "test-profile"

t.Run("compose up with profile", func(t *testing.T) {
res := c.RunDockerComposeCmd(t, "-f", "./fixtures/profiles/compose.yaml",
"-p", projectName, "--profile", profileName, "up", "-d")
res.Assert(t, icmd.Expected{ExitCode: 0})
res = c.RunDockerComposeCmd(t, "-p", projectName, "ps")
res.Assert(t, icmd.Expected{Out: "profiled-service"})
res.Assert(t, icmd.Expected{Out: "main"})
})

t.Run("compose stop with profile", func(t *testing.T) {
res := c.RunDockerComposeCmd(t, "-f", "./fixtures/profiles/compose.yaml",
"-p", projectName, "--profile", profileName, "stop")
res.Assert(t, icmd.Expected{ExitCode: 0})
res = c.RunDockerComposeCmd(t, "-p", projectName, "ps", "--status", "running")
assert.Assert(t, !strings.Contains(res.Combined(), "profiled-service"))
assert.Assert(t, !strings.Contains(res.Combined(), "main"))
})

t.Run("compose start with profile", func(t *testing.T) {
res := c.RunDockerComposeCmd(t, "-f", "./fixtures/profiles/compose.yaml",
"-p", projectName, "--profile", profileName, "start")
res.Assert(t, icmd.Expected{ExitCode: 0})
res = c.RunDockerComposeCmd(t, "-p", projectName, "ps", "--status", "running")
res.Assert(t, icmd.Expected{Out: "profiled-service"})
res.Assert(t, icmd.Expected{Out: "main"})
})

t.Run("compose restart with profile", func(t *testing.T) {
res := c.RunDockerComposeCmd(t, "-f", "./fixtures/profiles/compose.yaml",
"-p", projectName, "--profile", profileName, "restart")
res.Assert(t, icmd.Expected{ExitCode: 0})
res = c.RunDockerComposeCmd(t, "-p", projectName, "ps", "--status", "running")
res.Assert(t, icmd.Expected{Out: "profiled-service"})
res.Assert(t, icmd.Expected{Out: "main"})
})

t.Run("down", func(t *testing.T) {
_ = c.RunDockerComposeCmd(t, "--project-name", projectName, "down")
})

t.Run("check containers after down", func(t *testing.T) {
res := c.RunDockerCmd(t, "ps", "--all")
assert.Assert(t, !strings.Contains(res.Combined(), projectName), res.Combined())
})
}