Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change touch-action wording, add touch-action to examples #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srmagura
Copy link

@srmagura srmagura commented Sep 6, 2021

See discussion on clauderic/dnd-kit#435

@osmancalikoglu
Copy link

osmancalikoglu commented Jan 8, 2024

Thanks @srmagura but I suggest you to change readme files with informing usage of either PointerSensor or TouchSensor instead of recommending touch-action: none;.

TouchSensor works pretty fine on mobile devices and PointerSensor works pretty fine on web devices. No need to manipulate touch-action CSS property on touch devices because it causes different issues like unable to sorting or scrolling properly etc.

Problem can be simply solved by detecting target device and determining which sensor to be used. I prefer to see this in the documentation explained with your sight.

See detailed example case and my screenshot on clauderic/dnd-kit#435 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants