You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The DynamicalReflectivityModel does not use the resolution_width, sample_width, and beam_width parameters which SpecularReflectivity is using.
Does it make sense to add this functionality or do these parameters not make sense here?
My feeling is that since the two models calculate almost the same thing it that the parameters should be added. I guess that resolution_width is in particular easy since its just a convolution of the result where the respective function is already available in Model.convolute_resolution(x, y)
The other two might be more complicated since a consistent handling should be found for transmitivity and reflectivity.
The text was updated successfully, but these errors were encountered:
The
DynamicalReflectivityModel
does not use theresolution_width
,sample_width
, andbeam_width
parameters which SpecularReflectivity is using.Does it make sense to add this functionality or do these parameters not make sense here?
My feeling is that since the two models calculate almost the same thing it that the parameters should be added. I guess that
resolution_width
is in particular easy since its just a convolution of the result where the respective function is already available inModel.convolute_resolution(x, y)
The other two might be more complicated since a consistent handling should be found for transmitivity and reflectivity.
The text was updated successfully, but these errors were encountered: