bug fix: AbstractProduct.primary_images() should check against... #4419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
oscar.apps.catalogue.abstract_models.AbstractProduct
, we have a method as follows:This looks benign and without issue, however, we do have a problem. It is on this line:
The problem here is if one overrides the Meta class on their own ProductImage model class, without specifying an
ordering
attribute, this results in anAttributeError
. I personally encountered this myself. Code snippet below:Due to the way that Django handles manifesting the Meta implementation, the correct way to refer to the real Meta class (which is actually an
Options
class after being processed) is by referencing_meta
, notMeta
directly. This small changes fixes this issue, and code like mine now works as expected.