Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo max_basket_applications #4339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benb10
Copy link

@benb10 benb10 commented Aug 29, 2024

Fix a typo - I think it should be max_basket_applications instead of max_user_applications

@benb10 benb10 marked this pull request as ready for review August 29, 2024 12:00
@viggo-devries
Copy link
Contributor

wow, please add a test to check this specific condition.

@viggo-devries viggo-devries added the Needs tests This pull request does not have sufficient tests label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (204b9a7) to head (1d60ce9).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/oscar/apps/offer/abstract_models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
+ Coverage   88.28%   88.40%   +0.12%     
==========================================
  Files         293      292       -1     
  Lines       16046    16100      +54     
==========================================
+ Hits        14166    14233      +67     
+ Misses       1880     1867      -13     
Files with missing lines Coverage Δ
src/oscar/apps/offer/abstract_models.py 89.30% <0.00%> (+0.14%) ⬆️

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs tests This pull request does not have sufficient tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants