-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include "typing" lib in install_requires
if Python 3.5+
#1168
Comments
Looks good. Could you make a PR for this ? |
Do not include "typing" lib in `install_requires` if Python 3.5+ #1168
* 'master' of github.com:django-extensions/django-extensions: Issue #1173: Fix ImportError on generate_password command with django 1.8. Issue #1173: Add document for new `generate_password` command. Issue #1173: Replace `get_random_string()` with `BaseUserManager.make_random_password()` for future maintenance. Issue #1173: Add new `generate_password` command. Do not include "typing" lib in `install_requires` if Python 3.5+ #1168
@trbs the fix #1170 only work if i install django-extensions with pip
my environment
I've looked for some way to fix this, but I'm still a bit confused as to the correct way to do this The closest I found it was |
@hynek do you have any comments on what is the current correct way to specify conditional dependencies in a way to work with a wheel package? |
@tdruez Hey man, maybe I am misreading how the setup.py works, but it seems to me like you are currently installing typing only if the Python Version is smaller than 3.5. |
@s-wirth the |
@luzfcb Ah yeah that makes sense. Thank you for the answer :) |
@luzfcb the most correct way is currently PEP 508 but the most compatible way appears to be the using |
related to #1176 |
Please test with Django Extensions 2.0.5 and hopefully that fixes the issues. |
If there other (edge) cases where it still fails please reopen the issue. |
From https://pypi.python.org/pypi/typing:
We should not force the install of
typing
for Python version 3.5 or later.I'm suggesting the following change:
@trbs let me know what you think.
The text was updated successfully, but these errors were encountered: