issue oppia#6482 fixed - Skill editor, Questions, button Save and Pub…

…lish Question is disable untill all requirements are fulfilled
discombobulateme · Nov 3, 2019 · a7bfc56 · a7bfc56
1 parent 8bbc77f
commit a7bfc56
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.../head/components/question-directives/modal-templates/question-editor-modal.directive.html b/.../head/components/question-directives/modal-templates/question-editor-modal.directive.html
@@ -22,5 +22,5 @@ <h3>
 </div>
 <div class="modal-footer">
   <button class="btn btn-secondary" ng-click="cancel()"> Cancel </button>
-  <button class="btn btn-success protractor-test-save-question-button" ng-click="done()"> Save and Publish Question </button>
+  <button class="btn btn-success protractor-test-save-question-button" ng-click="done()" ng-disabled="toggleEnableButton()"> Save and Publish Question </button>
 </div>
diff --git a/...plates/dev/head/components/question-directives/questions-list/questions-list.directive.ts b/...plates/dev/head/components/question-directives/questions-list/questions-list.directive.ts
@@ -134,6 +134,7 @@ angular.module('oppia').directive('questionsList', [
           ctrl.saveAndPublishQuestion = function() {
             var validationErrors = ctrl.question.validate(
               ctrl.misconceptionsBySkill);
+
             if (validationErrors) {
               AlertsService.addWarning(validationErrors);
               return;
@@ -473,6 +474,11 @@ angular.module('oppia').directive('questionsList', [
                     }
                     $uibModalInstance.close();
                   };
+                  // Checking if Question contains all requirement to enable Save and Publish Question
+                  $scope.toggleEnableButton = function(){
+                    return $scope.question.validate(
+                      $scope.misconceptionsBySkill);
+                  }
 
                   $scope.cancel = function() {
                     if (QuestionUndoRedoService.hasChanges()) {