Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column order for table layout in field interface is changed in the snapshot #20719

Open
Galaen opened this issue Dec 12, 2023 · 2 comments
Open

Column order for table layout in field interface is changed in the snapshot #20719

Galaen opened this issue Dec 12, 2023 · 2 comments
Labels
Bug Core Data Modeling

Comments

@Galaen
Copy link

Galaen commented Dec 12, 2023

Describe the Bug

I have a field "periods" (O2M) and I configure the "interface" of the field to use "table" as the Layout.
You can order your columns here :
image
But when you export this in a snapshot it dosen't keep the chosen order (seem alphabetical instead).
image

And once you re-import the snapshot the order is changed as in the snapshot.

It doesn't seem to me to be the expected behaviour.
At the moment, once the snapshot is created I have to edit the snapshot to change this order again

This comment seems to reference the same problem:
#19756 (comment)

To Reproduce

  • create 2 collections with fields
  • 1 collection field should be 02M and reference the other collection
  • when configuring this field go to "interface" and change the layout to "table"
  • add few fields and order them as you want (not alpha)
  • generate a snapshot (see the order not yours)
  • change something like adding a new column to force import to see a diff
  • apply the snapshot
  • you can now see the order changed in the interface (not the order you wanted)

Directus Version

v10.8.2

Hosting Strategy

Self-Hosted (Docker Image)
@arminfelke
Copy link

The same issue can also, for example, be observed with the toolbar of the WYSIWYG editor (v10.10.5, self-hosted (node)).
The actual order is lost when the snapshot is created. The toolbar buttons in the snaphost are sorted alphabetically.

@JohJonker
Copy link

Same for us: it seems all string arrays that are output in the schema get sorted by raw value. This has the knock-on effect of creating unnecessary diffs when calling the /schema/diff endpoint, since the internal snapshot used to compare against the incoming schema doesn't reflect the correct array order, meaning that a diff is created every time to try to "restore" it.

As far as I can see the automatic sorting behaviour is introduced by sortDeep in api/src/utils/get-snapshot.ts, i.e.:

if (isArray(raw)) {
   return sortBy(raw);
}

@hanneskuettner hanneskuettner self-assigned this Apr 23, 2024
@hanneskuettner hanneskuettner removed their assignment Aug 5, 2024
@rijkvanzanten rijkvanzanten added the Engine label Aug 28, 2024 — with Linear
@rijkvanzanten rijkvanzanten added the Bug label Sep 2, 2024 — with Linear
@rijkvanzanten rijkvanzanten added the Directus label Nov 25, 2024 — with Linear
@rijkvanzanten rijkvanzanten added the Core label Nov 25, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Core Data Modeling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hanneskuettner @JohJonker @Galaen @rijkvanzanten @arminfelke