Remove jest-dom

Remove dependency on jest-dom as it was no longer being used apart from 2 instances of `toHaveTextContent` which were trivially updated to use `getByText` instead.
dippynark · Jun 10, 2020 · 2f8fa5b · 2f8fa5b
1 parent 760dba4
commit 2f8fa5b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 179 deletions.
diff --git a/config_frontend/setupTests.js b/config_frontend/setupTests.js
@@ -12,7 +12,6 @@ limitations under the License.
 */
 
 import 'react-testing-library/cleanup-after-each';
-import 'jest-dom/extend-expect';
 import fetchMock from 'fetch-mock';
 
 fetchMock.catch();

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -89,7 +89,6 @@
     "glob": "^7.1.4",
     "html-webpack-plugin": "^3.2.0",
     "jest": "^25.3.0",
-    "jest-dom": "^3.4.0",
     "lerna": "^3.16.4",
     "lodash.difference": "^4.5.0",
     "lodash.omit": "^4.5.0",

diff --git a/src/containers/TriggerTemplate/TriggerTemplate.test.js b/src/containers/TriggerTemplate/TriggerTemplate.test.js
@@ -271,7 +271,7 @@ it('TriggerTemplateContainer renders resource templates', async () => {
     }
   };
 
-  const { getByText, getByTestId } = renderWithRouter(
+  const { getByText } = renderWithRouter(
     <TriggerTemplateContainer
       intl={intl}
       match={match}
@@ -282,13 +282,8 @@ it('TriggerTemplateContainer renders resource templates', async () => {
   );
 
   await waitForElement(() => getByText('pipeline-template'));
-
-  await waitForElement(() => getByText(resourceTemplate1NameInfo));
-  await waitForElement(() => getByText(resourceTemplate2NameInfo));
-
-  const resourceTemplatesTable = getByTestId('resourcetemplatestable');
-  expect(resourceTemplatesTable).toHaveTextContent(resourceTemplate1NameInfo);
-  expect(resourceTemplatesTable).toHaveTextContent(resourceTemplate2NameInfo);
+  expect(getByText(resourceTemplate1NameInfo)).toBeTruthy();
+  expect(getByText(resourceTemplate2NameInfo)).toBeTruthy();
 });
 
 it('TriggerTemplateContainer renders full resource template information', async () => {