offer default implement for base language model

dinsy008 · Sep 11, 2023 · c54a9a7 · c54a9a7
1 parent 4153d69
commit c54a9a7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 22 deletions.
diff --git a/langchain-core/src/main/java/com/hw/langchain/base/language/BaseLanguageModel.java b/langchain-core/src/main/java/com/hw/langchain/base/language/BaseLanguageModel.java
@@ -39,7 +39,9 @@ public interface BaseLanguageModel {
     /**
      * Predict text from text.
      */
-    String predict(String text);
+    default String predict(String text) {
+        return predict(text, null);
+    }
 
     /**
      * Predict text from text.
@@ -49,10 +51,14 @@ public interface BaseLanguageModel {
     /**
      * Predict message from messages.
      */
-    BaseMessage predictMessages(List<BaseMessage> messages);
+    default BaseMessage predictMessages(List<BaseMessage> messages) {
+        return predictMessages(messages, null);
+    }
 
     /**
      * Predict message from messages.
      */
     BaseMessage predictMessages(List<BaseMessage> messages, List<String> stop);
+
+
 }
diff --git a/langchain-core/src/main/java/com/hw/langchain/chat/models/base/BaseChatModel.java b/langchain-core/src/main/java/com/hw/langchain/chat/models/base/BaseChatModel.java
@@ -90,11 +90,6 @@ public BaseMessage call(List<BaseMessage> messages, List<String> stop) {
         }
     }
 
-    @Override
-    public String predict(String text) {
-        return predict(text, null);
-    }
-
     @Override
     public String predict(String text, List<String> stop) {
         List<String> copyStop = stop != null ? List.copyOf(stop) : null;
@@ -104,11 +99,6 @@ public String predict(String text, List<String> stop) {
         return result.getContent();
     }
 
-    @Override
-    public BaseMessage predictMessages(List<BaseMessage> messages) {
-        return predictMessages(messages, null);
-    }
-
     @Override
     public BaseMessage predictMessages(List<BaseMessage> messages, List<String> stop) {
         List<String> copyStop = stop != null ? List.copyOf(stop) : null;

diff --git a/langchain-core/src/main/java/com/hw/langchain/llms/base/BaseLLM.java b/langchain-core/src/main/java/com/hw/langchain/llms/base/BaseLLM.java
@@ -70,21 +70,11 @@ public LLMResult generatePrompt(List<PromptValue> prompts, List<String> stop) {
         return generate(promptStrings, stop);
     }
 
-    @Override
-    public String predict(String text) {
-        return predict(text, null);
-    }
-
     @Override
     public String predict(String text, List<String> stop) {
         return call(text, stop);
     }
 
-    @Override
-    public BaseMessage predictMessages(List<BaseMessage> messages) {
-        return predictMessages(messages, null);
-    }
-
     @Override
     public BaseMessage predictMessages(List<BaseMessage> messages, List<String> stop) {
         return null;