Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parry update (0.18?) #770

Merged
merged 11 commits into from
Jan 8, 2025
Merged

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Dec 6, 2024

See following trace with example 2d 100 x 100 balls:

  • 🟨 this trace is master (traverse_best_first)
  • 🟥 external trace is this PR (traverse_depth_first)

image

features = ["parallel", "profiling"]
features = ["parallel", "profiler_ui"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature change name is to avoid naming a feature the same as a dependency, + better represent what this does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure, but I encountered problems with enabling profiling/profile-with-tracy without that change (because you cannot profile with 2 backends (puffin+tracy)), I imagine that enabled profiling too, so that feature name change would have fixed it.

@Vrixyz Vrixyz changed the title Parry update simpler traverse Parry update (0.18?) Dec 6, 2024
@sebcrozet sebcrozet force-pushed the parry_update-simpler_traverse branch from c5098ec to 65b8ca0 Compare January 8, 2025 15:33
@sebcrozet sebcrozet merged commit dc4bd24 into dimforge:master Jan 8, 2025
8 checks passed
@sebcrozet
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants