store da-ghc-lib on a GCS bucket #209
Conversation
garyverhaegen-da
requested review from
cocreature,
shayne-fletcher,
hurryabit and
a user
At the moment, publishing a new version of da-ghc-lib (the one DAML depends on) is a manual process aimed at Bintray. As we have just received a note from JFrog that Bintray is sunsetting, this is a good opportunity to automate the deployment. This PR aims at creating a GCS bucket (Terraform files to be applied manually) and change the CI process to push every master commit to said GCS bucket.
garyverhaegen-da
force-pushed
the
store-da-ghc-lib-on-bucket
branch
from
b3c4eab to
d6ce2ec
Compare
|
Note: as of opening this PR, there are a number of missing pieces:
Additional notes:
|
|
Oh and also as usual once this is all done and applied and merged we'll still need Ed to create the DNS entry before the bucket is actually useable. |
There was a problem hiding this comment.
One small thing found and noted inline that looks wrong (wrong ghc-flavor).
Some general notes:
- I'm a little unclear on how the new strategy is intended to work;
- If it's an automated build/upload on push then ghc-lib isn't the right repo to be watching, it's commits to the
da-master-8.8.1branch of git@github.com:digital-asset/ghc.git that should trigger uploads; - Not sure about the calculation of
VERSION_TAG- will it match whatCI.hsgenerates for the tarball name(s)? What happens if you find yourself needing to do a second one on the same day? e.g. ghc-lib-8.10.1.20200518.1.tar.gz - There are two tarballs produced during the build ghc-lib-parser and ghc-lib - that does seem accounted for
- The code in ghc-lib/CI.hs needs updating to remove/replace the bintray bits and that's not here (yet).
|
|
||
| VERSION_TAG="$(git log -n1 --format=%cd --date=format:%Y%m%d HEAD).$(git rev-list --count HEAD).$(git log -n1 --format=%h --abbrev=8 HEAD)" | ||
|
|
||
| stack runhaskell --package extra --package optparse-applicative CI.hs -- --ghc-flavor=ghc-8.8.1 |
There was a problem hiding this comment.
The flavor for DA is da-ghc-8.8.1.
Could be a small enhancement to CI.hs might help here (maybe, maybe not). I've implemented a |
|
This is the wrong repo for this, and probably the wrong approach. Thanks @shayne-fletcher for all the additional context; closing this for now. |
|
I’m not sure this is necessarily the wrong repo. It depends on both. Right now, there is no CI on the ghc repo at all so adding it here seems like a reasonable option. We could just have a single file that locks down the revision and if that changes we publish. |
Indeed. Gary and I ended up discussing that scheme and it may well be what gets done. He's mulling it over. |
|
For anyone stumbling on this in the future and finding the suspense unbearable, this has been implemented across both this and the daml repo as digital-asset/daml#6188 and #215. |
|
Thanks @garyverhaegen-da ! |
At the moment, publishing a new version of da-ghc-lib (the one DAML depends on) is a manual process aimed at Bintray. As we have just received a note from JFrog that Bintray is sunsetting, this is a good opportunity to automate the deployment.
This PR aims at creating a GCS bucket (Terraform files to be applied manually) and change the CI process to push every master commit to said GCS bucket.