Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF : Fix/Clean some LF related TODOs #8387

Merged
merged 6 commits into from
Jan 7, 2021
Merged

LF : Fix/Clean some LF related TODOs #8387

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79c18be
LF : Fix/Clean some LF related TODOs
remyhaemmerle-da Jan 5, 2021
1c65896
reformat some TODO anotations
remyhaemmerle-da Jan 5, 2021
51e8a06
fix flaky test
remyhaemmerle-da Jan 5, 2021
a1312a2
revert wrong ignore in TransactionCoderSpec
remyhaemmerle-da Jan 5, 2021
8236718
Address reviews.
remyhaemmerle-da Jan 7, 2021
908051c
starting to fix com.daml.navigator.query.ContractSortSpec
remyhaemmerle-da Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reformat some TODO anotations
  • Loading branch information
@remyhaemmerle-da
remyhaemmerle-da committed Jan 7, 2021
commit 1c6589657e9a3856de2d314863e256f3bfb30144
2 changes: 1 addition & 1 deletion daml-lf/interface/src/main/scala/com/digitalasset/daml/lf/iface/reader/InterfaceReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ object InterfaceReader {
case Ast.BTGenMap => \/-((2, PrimType.GenMap))
case Ast.BTAnyException | Ast.BTGeneralError | Ast.BTArithmeticError |
Ast.BTContractError =>
// TODO: https://github.com/digital-asset/daml/issues/8020
// TODO https://github.com/digital-asset/daml/issues/8020
// Add exception types to the interface reader
unserializableDataType(
ctx,
Expand Down
4 changes: 3 additions & 1 deletion daml-lf/language/src/test/scala/com/digitalasset/daml/lf/language/AstSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ class AstSpec extends AnyWordSpec with TableDrivenPropertyChecks with Matchers {
name = name,
consuming = true,
controllers = eParties,
choiceObservers = None, //FIXME #7709: need test for the Some case
// TODO https://github.com/digital-asset/daml/issues/7709
// need test for the Some case
choiceObservers = None,
selfBinder = Name.assertFromString("self"),
argBinder = Name.assertFromString("arg") -> TUnit,
returnType = TUnit,
Expand Down
2 changes: 1 addition & 1 deletion ...ransaction/src/test/scala/com/digitalasset/daml/lf/transaction/TransactionCoderSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ class TransactionCoderSpec
): Map[NodeId, GenNode[NodeId, ContractId]] =
nodes.transform((_, gn) => minimalistNode(txvMin)(gn))

// FIXME: https://github.com/digital-asset/daml/issues/7709
// TODO https://github.com/digital-asset/daml/issues/7709
// The following function should be usefull to test choice observers
def minimalistTx(
txvMin: TransactionVersion,
Expand Down
2 changes: 1 addition & 1 deletion extractor/src/test/suite/scala/com/digitalasset/extractor/GenMapSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class GenMapSpec
with CustomMatchers {

override protected def darFile =
// TODO: https://github.com/digital-asset/daml/issues/7139
// TODO https://github.com/digital-asset/daml/issues/7139
// Change to "daml-lf/encoder/test-1.11.dar" once 1.11 is frozen
new File(rlocation("daml-lf/encoder/test-1.dev.dar"))

Expand Down
4 changes: 3 additions & 1 deletion ...t-integration-api/src/test/lib/scala/platform/store/dao/JdbcLedgerDaoDivulgenceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ private[dao] trait JdbcLedgerDaoDivulgenceSpec extends LoneElement with Inside {
chosenValue = someValueRecord,
stakeholders = Set(alice, bob),
signatories = Set(alice),
choiceObservers = Set.empty, //FIXME #7709, also test the case of non-empty choice-observers
// TODO https://github.com/digital-asset/daml/issues/7709
// also test the case of non-empty choice-observers
choiceObservers = Set.empty,
children = ImmArray.empty,
exerciseResult = None,
key = None,
Expand Down