Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-api: Use proto_jars, and publish Protobuf sources separately from the Scala classes. [KVL-714] #8091

Merged
merged 7 commits into from
Nov 27, 2020
Merged

ledger-api: Use proto_jars, and publish Protobuf sources separately from the Scala classes. [KVL-714] #8091

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4602455
ledger-api: Use `proto_jars`.
SamirTalwar Nov 26, 2020
46ac42c
Create a source JAR for *.proto files in `proto_jars`.
SamirTalwar Nov 27, 2020
35db022
ledger-api: Publish the protobuf sources as "ledger-api-proto".
SamirTalwar Nov 27, 2020
cf0e787
release: We don't need the "main-jar" option.
SamirTalwar Nov 27, 2020
b4898e2
Bazel: Proto JARs will always have a Maven artifact suffix.
SamirTalwar Nov 27, 2020
657d0fb
Bazel: Simplify Protobuf source file TAR and JAR targets.
SamirTalwar Nov 27, 2020
fbe78ed
Bazel: Extract out Protobuf functions.
SamirTalwar Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bazel: Proto JARs will always have a Maven artifact suffix.
  • Loading branch information
@SamirTalwar
SamirTalwar committed Nov 27, 2020
commit b4898e2004f8b10657efcee14b63a5b1f205546b
2 changes: 1 addition & 1 deletion bazel_tools/proto.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def _is_windows(ctx):

def maven_tags(group, artifact_prefix, artifact_suffix):
if group and artifact_prefix:
artifact = artifact_prefix + "-" + artifact_suffix if artifact_suffix else artifact_prefix
artifact = artifact_prefix + "-" + artifact_suffix
return ["maven_coordinates=%s:%s:__VERSION__" % (group, artifact)]
else:
return []
Expand Down