Distinguish witnesses and divulgences in scenario table view #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we display a "D" (for "Disclosure/Divulgence") in the table view of the scenario view when a party can see a contract because they have learnt about it via disclosure. This change further refines this visibily indicators for disclosure: We display a "W" for "Witness" (i.e. the party has witnessed the creation of the contract) and "D" for "Divulgence". Help for the reviewer: In the scenario service server, witnessing is called explicit disclosure whereas divulgence is called implicit disclosure. CHANGELOG_BEGIN * [DAML Studio] When displaying scenario results in table view in DAML Studio, we now indicate _why_ a party knows about the existence of a contract: - `S` means the party is a signatory. - `O` means the party is an observer. - `W` means the party has witnessed the creation of the contract. - `D` means the party has learned about the contract via divulgence. CHANGELOG_END
|
|
cocreature
approved these changes
Jul 2, 2020
| @@ -83,7 +83,7 @@ object ScenarioLedger { | |||
| globalImplicitDisclosure: Relation[ContractId, Party], | |||
| failedAuthorizations: FailedAuthorizations, | |||
| ) { | |||
| def disclosures(coidToEventId: ContractId => EventId): Relation[EventId, Party] = | |||
| def disclosures(coidToEventId: ContractId => EventId): Map[EventId, Set[Party]] = | |||
There was a problem hiding this comment.
While I’m not really a fan of synonyms it also seems a bit confusing to work with Relation.… in the body of this method but then not use the type synonym.
There was a problem hiding this comment.
Good catch. That's a relic from a failed attempt to change some things. I'll bring it back to its original state. I should have self-reviewed my PR better. 😞
| _.addDisclosures(witnesses.map(_ -> Disclosure(since = trId, explicit = true)).toMap)) | ||
| } | ||
| richTr.globalImplicitDisclosure.foldLeft(cacheWithExplicitDisclosures) { | ||
| case (cacheP, (coid, witnesses)) => |
There was a problem hiding this comment.
Shouldn’t witnesses be called divulgees here?
There was a problem hiding this comment.
That's a good idea. Thanks. I blindly copied the old code...
garyverhaegen-da
added a commit
that referenced
this pull request
Jul 2, 2020
As requested by @shaul-da, this PR hides the information added by @hurryabit in #6571 behind a checkbox, and reverts to plain "X"s by default (checkbox unchecked). CHANGELOG_BEGIN - [DAML Studio] The new S/O/W/D information is hidden behind a top-level checkbox (next to Show archived). When that checkbox is not checked (which is the default), we display X's as before. CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jul 2, 2020
As requested by @shaul-da, this PR hides the information added by @hurryabit in #6571 behind a checkbox, and reverts to plain "X"s by default (checkbox unchecked). CHANGELOG_BEGIN - [DAML Studio] The new S/O/W/D information is hidden behind a top-level checkbox (next to Show archived). When that checkbox is not checked (which is the default), we display X's as before. CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jul 2, 2020
As requested by @shaul-da, this PR hides the information added by @hurryabit in #6571 behind a checkbox, and reverts to plain "X"s by default (checkbox unchecked). CHANGELOG_BEGIN - [DAML Studio] The new S/O/W/D information is hidden behind a top-level checkbox (next to Show archived). When that checkbox is not checked (which is the default), we display X's as before. CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jul 3, 2020
As requested by @shaul-da, this PR hides the information added by @hurryabit in #6571 behind a checkbox, and reverts to plain "X"s by default (checkbox unchecked). CHANGELOG_BEGIN - [DAML Studio] The new S/O/W/D information is hidden behind a top-level checkbox (next to Show archived). When that checkbox is not checked (which is the default), we display X's as before. CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jul 3, 2020
As requested by @shaul-da, this PR hides the information added by @hurryabit in #6571 behind a checkbox, and reverts to plain "X"s by default (checkbox unchecked). CHANGELOG_BEGIN - [DAML Studio] The new S/O/W/D information is hidden behind a top-level checkbox (next to Show archived). When that checkbox is not checked (which is the default), we display X's as before. CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we display a "D" (for "Disclosure/Divulgence") in the table
view of the scenario view when a party can see a contract because they
have learnt about it via disclosure.
This change further refines this visibily indicators for disclosure:
We display a "W" for "Witness" (i.e. the party has witnessed the
creation of the contract) and "D" for "Divulgence".
Help for the reviewer: In the scenario service server, witnessing is
called explicit disclosure whereas divulgence is called implicit
disclosure.
CHANGELOG_BEGIN
When displaying scenario results in table view in DAML Studio, we now
indicate why a party knows about the existence of a contract:
Smeans the party is a signatory.Omeans the party is an observer.Wmeans the party has witnessed the creation of the contract.Dmeans the party has learned about the contract via divulgence.CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.
This change is