Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger service: Write packages to database if we have one #6424

Merged
merged 7 commits into from
Jun 19, 2020
Merged

Trigger service: Write packages to database if we have one #6424

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72fed9b
Trigger service: Write packages to database if we have one
rohanjr Jun 17, 2020
a47df53
Update comments re existing packages
rohanjr Jun 19, 2020
eed0754
Fix traverse
rohanjr Jun 19, 2020
b5f0efc
Ignore repeated package uploads
rohanjr Jun 19, 2020
ee75b4d
Tweak error msg
rohanjr Jun 19, 2020
df654e3
Comment for in-memory persistPackages
rohanjr Jun 19, 2020
2315bb2
Test for repeated package uploads
rohanjr Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test for repeated package uploads
  • Loading branch information
@rohanjr
rohanjr committed Jun 19, 2020
commit 2315bb25338438953484bbf522ed729375e562f6
10 changes: 10 additions & 0 deletions ...s/service/src/test/scala/com/digitalasset/daml/lf/engine/trigger/TriggerServiceTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,16 @@ abstract class AbstractTriggerServiceTest extends AsyncFlatSpec with Eventually
Future(succeed)
}

it should "allow repeated uploads of the same packages" in
withTriggerService(Some(dar)) { (uri: Uri, client: LedgerClient, ledgerProxy: Proxy) =>
for {
resp <- uploadDar(uri, darPath) // same dar as in initialization
_ <- parseResult(resp)
resp <- uploadDar(uri, darPath) // same dar again
_ <- parseResult(resp)
} yield succeed
}

it should "fail to start non-existent trigger" in withTriggerService(Some(dar)) {
(uri: Uri, client: LedgerClient, ledgerProxy: Proxy) =>
val expectedError = StatusCodes.UnprocessableEntity
Expand Down