Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment Windows cache URL #6321

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Increment Windows cache URL #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ function bazel() {
# which is a workaround for this problem.
bazel shutdown

bazel clean --expunge

# Prefetch nodejs_dev_env to avoid permission denied errors on external/nodejs_dev_env/nodejs_dev_env/node.exe
# It isn’t clear where exactly those errors are coming from.
bazel fetch @nodejs_dev_env//...
Expand Down
2 changes: 1 addition & 1 deletion ci/configure-bazel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ if is_windows; then
SUFFIX="${SUFFIX:0:3}"
echo "Platform suffix: $SUFFIX"
# We include an extra version at the end that we can bump manually.
CACHE_SUFFIX="$SUFFIX-v2"
CACHE_SUFFIX="$SUFFIX-v3"
CACHE_URL="$CACHE_URL/$CACHE_SUFFIX"
echo "build:windows-ci --remote_http_cache=https://bazel-cache.da-ext.net/$CACHE_SUFFIX" >> .bazelrc.local
fi
Expand Down
1 change: 1 addition & 0 deletions compatibility/build-release-artifacts-windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ function bazel() {


bazel shutdown
bazel clean --expunge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to merge the clean --expunge? I guess in this case, that’s the only option since it doesn’t just affect the compat node which we can reset fairly easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and then remove it after the nodes were reset. To avoid poisoning the fresh cache with broken items in the local cache of some nodes.

bazel fetch @nodejs_dev_env//...
bazel build `
`-`-experimental_execution_log_file ${ARTIFACT_DIRS}/build_execution_windows.log `
Expand Down
1 change: 1 addition & 0 deletions compatibility/test-windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ cd compatibility
cp ../.bazelrc .bazelrc

bazel shutdown
bazel clean --expunge
bazel fetch @nodejs_dev_env//...
bazel build //...
bazel shutdown
Expand Down