Increment Windows cache URL #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen a series of failures of the form ``` ERROR: D:/a/1/s/daml-assistant/integration-tests/BUILD.bazel:162:1: output 'daml-assistant/integration-tests/create-daml-app-tests.exe' was not created ERROR: D:/a/1/s/daml-assistant/integration-tests/BUILD.bazel:162:1: not all outputs were created or valid ``` across multiple machines. We suspect cache poisoning as the cause. This increments the cache URL to effectively clear the cache. changelog_begin changelog_end
cocreature
approved these changes
Jun 12, 2020
| @@ -37,6 +37,7 @@ function bazel() { | |||
|
|
|||
|
|
|||
| bazel shutdown | |||
| bazel clean --expunge | |||
There was a problem hiding this comment.
Do you want to merge the clean --expunge? I guess in this case, that’s the only option since it doesn’t just affect the compat node which we can reset fairly easily.
There was a problem hiding this comment.
Yes, and then remove it after the nodes were reset. To avoid poisoning the fresh cache with broken items in the local cache of some nodes.
|
All nodes have been reset. |
garyverhaegen-da
added a commit
that referenced
this pull request
Jun 12, 2020
See #6321 CHANGELOG_BEGIN CHANGELOG_END
Merged
garyverhaegen-da
added a commit
that referenced
this pull request
Jun 12, 2020
See #6321 CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a series of failures of the form
across multiple machines. We suspect cache poisoning as the cause. This
increments the cache URL to effectively clear the cache.
See #6262
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.