DAML-LF: factorize ScenarioNodeId and EventId #6256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
SamirTalwar,
gerolf-da and
stefanobaghino-da
remyhaemmerle-da
requested review from
cocreature,
hurryabit and
rautenrieth-da
as code owners
remyhaemmerle-da
added
component/daml-engine
remyhaemmerle-da
force-pushed
the
remy-drop-scenarion-node-id
branch
from
6070905 to
4763831
Compare
CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
force-pushed
the
remy-drop-scenarion-node-id
branch
from
4763831 to
4fd18d9
Compare
stefanobaghino-da
approved these changes
Jun 8, 2020
ledger/sandbox/src/test/lib/scala/com/digitalasset/platform/store/dao/JdbcLedgerDaoSuite.scala
Outdated
Show resolved
Hide resolved
| @@ -225,6 +225,7 @@ da_scala_library( | |||
| "//daml-lf/archive:daml_lf_archive_reader", | |||
| "//daml-lf/archive:daml_lf_dev_archive_java_proto", | |||
| "//daml-lf/data", | |||
| "//daml-lf/interpreter", | |||
There was a problem hiding this comment.
//daml-lf/interpreter is where Speedy lives, right? Does it make sense for it to be a direct dependency of the sandbox? Any chance we can keep those separated?
There was a problem hiding this comment.
Moving into the sandbox in the current state, it is clearly not an option.
However, If you are keen on dropping this dependency, I could move the data type definition in "//daml-lf/transaction" (which is a fair dependency) in an upcoming PR.
There was a problem hiding this comment.
Makes sense thanks, I created #6260 so that you can use it to track it in the the upcoming PR you mentioned.
ledger/sandbox/src/main/scala/com/digitalasset/platform/events/EventIdFormatter.scala
Show resolved
Hide resolved
ledger/sandbox/src/main/scala/com/digitalasset/platform/store/dao/JdbcLedgerDao.scala
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Jun 8, 2020
...n/scala/com/digitalasset/platform/apiserver/services/transaction/ApiTransactionService.scala
Outdated
Show resolved
Hide resolved
ledger/sandbox/src/main/scala/com/digitalasset/platform/store/dao/JdbcLedgerDao.scala
Outdated
Show resolved
Hide resolved
ghost
removed the request for review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sandbox and Scenario-service share the notion of
ScenarioNodeIdandEventIdbut used different type.This PR makes the sharing explicit but dropping the
ScenarioNodeIdand using a commonEventIdthat also make explicit the
TransactionIdandNodeIdcomponent in theEventId.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.