Fix variable in daily slack notifications #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 4, 2020
|
Started daily compat on this branch so we can test before merging. I guess I was too distracted by the Windows failures to notice this error message hidden behind a green dot on Azure. |
|
Daily compat (mac) test did succeed without printing the error, so this is indeed the correct Azure syntax. Thanks! |
garyverhaegen-da
approved these changes
Jun 4, 2020
ghost
reviewed
Jun 4, 2020
cocreature
force-pushed
the
fix-daily-tell-slack
branch
from
a2c2e1f to
5a7551a
Compare
Currently the report fails with variables[Build.SourceBranchName]: command not found which is obviously not what we want (it’s mixing up the syntax in Azure’s yaml config and Bash). Looking at the code in the tell-slack-failed.yml, this one does seem to work but I haven’t tested this so :crossed-fingers:. changelog_begin changelog_end
cocreature
force-pushed
the
fix-daily-tell-slack
branch
from
5a7551a to
853bccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the report fails with variables[Build.SourceBranchName]:
command not found which is obviously not what we want (it’s mixing up
the syntax in Azure’s yaml config and Bash). Looking at the
code in the tell-slack-failed.yml, this one does seem to work but I
haven’t tested this so :crossed-fingers:.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.