Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update perf tests SHA #5971

Merged
merged 2 commits into from
May 13, 2020
Merged

Update perf tests SHA #5971

merged 2 commits into from
May 13, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

This reflect harmless change from #5966

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da changed the title Remy perf test sha Update perf tests SHA May 13, 2020
cocreature
cocreature reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you’ve committed much more than you intended to?

@remyhaemmerle-da
update Perfs test sha
e88b7db
@remyhaemmerle-da
changelog
b765b46 
CHANGELOG_BEGIN
CHANGELOG_END
cocreature
cocreature approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hurryabit
hurryabit approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks about right. Thanks.

@mergify mergify bot merged commit b1c09ce into master May 13, 2020
@mergify mergify bot deleted the remy-perf-test-sha branch May 13, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @cocreature @hurryabit