Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: Remove optionality of contract ID Seeding. #5966

Merged
merged 5 commits into from
May 13, 2020
Merged

Engine: Remove optionality of contract ID Seeding. #5966

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bceaf7
Engine: remove optionality of contract ID seeding
remyhaemmerle-da May 13, 2020
d91d873
Apply suggestions from code review
remyhaemmerle-da May 13, 2020
6be351c
Address Samir's review
remyhaemmerle-da May 13, 2020
fbf6a21
Address Stephen's review
remyhaemmerle-da May 13, 2020
1c31fcd
fix tests
remyhaemmerle-da May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Samir Talwar <samir.talwar@digitalasset.com>
  • Loading branch information
@remyhaemmerle-da @SamirTalwar
remyhaemmerle-da and SamirTalwar authored May 13, 2020
commit d91d873fa26488e83cb649a85f82ccd74b29225a
4 changes: 2 additions & 2 deletions .../interpreter/src/main/scala/com/digitalasset/daml/lf/transaction/PartialTransaction.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ case class PartialTransaction(
copy(
context = ec.parent.addChild(nodeId),
nodes = nodes.updated(nodeId, exerciseNode),
nodeSeeds = nodeSeeds :+ (nodeId -> (nodeSeed)),
nodeSeeds = nodeSeeds :+ (nodeId -> nodeSeed),
)
case None =>
noteAbort(Tx.EndExerciseInRootContext)
Expand Down Expand Up @@ -425,7 +425,7 @@ case class PartialTransaction(
sealed abstract class InitialSeeding extends Product with Serializable

object InitialSeeding {
// NoSeed may be used to initiale machines that are not intended to create transactions
// NoSeed may be used to initialize machines that are not intended to create transactions
// e.g. trigger and script runners, tests
final case object NoSeed extends InitialSeeding
final case class TransactionSeed(seed: crypto.Hash) extends InitialSeeding
Expand Down