-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Draft version constraint generation #5472
Merged
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
040ef56
Draft version constraint generation
Gertjan423 0205507
Some code cleanup
Gertjan423 3476a5e
Substitution functions
Gertjan423 4675fdd
Template generation
Gertjan423 afc3766
Reformatted
Gertjan423 c329b37
Attempt to fix failing check
Gertjan423 f3e4d17
Rework generation for value definitions into 2 phase approach
Gertjan423 a7ef445
Various small changes
Gertjan423 c99827d
Rework delta to env state
Gertjan423 28eb1bb
Incorporate data type definitions
Gertjan423 80bb27a
Various constraint generation bug fixes and improvements
Gertjan423 220d21d
First part of constraint solving
Gertjan423 2bad89e
Minor bugfixes
Gertjan423 733f929
Added simple-smt to bazel
Gertjan423 5545943
Depend on z3
cocreature b736d85
Working pipeline
Gertjan423 4bc25cb
Fix overwriting value definitions, and delayed choice bindings
Gertjan423 310d7b0
Keep track of contract id's after fetching
Gertjan423 4b08356
Renaming of choice parameters
Gertjan423 e04944f
Cleanup
Gertjan423 18b0b97
Reals instead of ints
Gertjan423 2f3bf70
Various TODOs
Gertjan423 0911a90
Added function documentation
Gertjan423 6651d8d
Small bugfix
Gertjan423 a8e6c94
Conditionals and forward references
Gertjan423 50c56c3
Small missing arithmetic
Gertjan423 d880fa5
More small missing arithmetic
Gertjan423 aef855a
Fix daml 1.0.1 bug
Gertjan423 6c86c22
Read arguments and support fields in different templates
Gertjan423 1c21ff2
Proper verify output for testing, generate counter example, proper va…
Gertjan423 a33365c
Working testing framework, with some basic test cases
Gertjan423 64370c2
Testing: build daml instead of storing dar files
Gertjan423 f3bee74
Proper handling of update types; constraint synonyms
Gertjan423 13eb8a4
Additional equality constraints after create update
Gertjan423 16aa3e3
Make assertion print conditional
Gertjan423 642c1b9
Various improvements from PR feedback
Gertjan423 c791f31
Apply suggestions from code review
Gertjan423 ba1fad5
Small fix: Add missing import
Gertjan423 344eca8
Small fix: convert numerics
Gertjan423 1cdf6e4
Replace PRSelf with correct package reference
Gertjan423 cdbed09
Style fixes
Gertjan423 c62c276
Rework conditionals to remove When
Gertjan423 ed91ada
Cleanup test daml files
Gertjan423 b803eb9
Merge branch 'master' into daml-lf-verification
Gertjan423 a3ee542
Small style fixes
Gertjan423 91c989c
Bugfix after merge
Gertjan423 337b0ca
Attempt to fix bazel windows error
Gertjan423 49563b0
Attempt #2 to fix bazel windows error
Gertjan423 ae4a276
Attempt #3 to fix bazel windows error
Gertjan423 77ea060
Attempt #4 to fix bazel windows error
Gertjan423 2d7c840
Attempt #5 to fix bazel windows error
Gertjan423 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Conditionals and forward references
- Loading branch information
commit a8e6c948b6d9fc8e05a067fbb9b478c9d9aeab7c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this only works in our Bazel setup. We need to figure out what we do if we ship things to users. Not sure if we want to ship an SMT solver so a reasonable option might be to let users pass a path to the SMT solver they want to use.