Add specification for type synonyms in DAML-LF #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR advances the state of #3616. |
daml-lf/spec/daml-lf-1.rst
Outdated
| @@ -846,6 +852,14 @@ First, we formally defined *well-formed types*. :: | |||
| ————————————————————————————————————————————— TyTuple | |||
| Γ ⊢ ⟨ f₁: τ₁, …, fₙ: τₙ ⟩ : ⋆ | |||
|
|
|||
| 'synonym' S (α₁:k₁) … (αₙ:kₙ) ↦ τ ∈ 〚Ξ〛Mod | |||
| (α₁:k₁) … (αₙ:kₙ) · Γ ⊢ τ : ⋆ | |||
There was a problem hiding this comment.
Suggested change
| (α₁:k₁) … (αₙ:kₙ) · Γ ⊢ τ : ⋆ |
This line would better go in Well-formed definitions paragraph.
αₙ : kₙ · ⋯ · α₁ : k₁ ⊢ τ : ⋆
——————————————————————————————————————————————————————————————— DefSyn
⊢ 'synonym' S (α₁: k₁) … (αₙ: kₙ) ↦ τ
hurryabit
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Very nice. Thank you.
I agree with @remyhaemmerle-da on the well-formed definitions section.
daml-lf/spec/daml-lf-1.rst
Outdated
| @@ -676,6 +681,7 @@ available for usage:: | |||
| | 'variant' T (α₁: k₁)… (αₙ: kₙ) ↦ V₁ : τ₁ | … | Vₘ : τₘ | |||
| -- DefVariant | |||
| | 'enum' T ↦ E₁ | … | Eₘ -- DefEnum | |||
| | 'synonym' T (α₁: k₁)… (αₙ: kₙ) ↦ τ -- DefTypeSynonym | |||
There was a problem hiding this comment.
Suggested change
| | 'synonym' T (α₁: k₁)… (αₙ: kₙ) ↦ τ -- DefTypeSynonym | |
| | 'synonym' S (α₁: k₁)… (αₙ: kₙ) ↦ τ -- DefTypeSynonym |
daml-lf/spec/daml-lf-1.rst
Outdated
| @@ -846,6 +852,14 @@ First, we formally defined *well-formed types*. :: | |||
| ————————————————————————————————————————————— TyTuple | |||
| Γ ⊢ ⟨ f₁: τ₁, …, fₙ: τₙ ⟩ : ⋆ | |||
|
|
|||
| 'synonym' T (α₁:k₁) … (αₙ:kₙ) ↦ τ ∈ 〚Ξ〛Mod | |||
There was a problem hiding this comment.
Suggested change
| 'synonym' T (α₁:k₁) … (αₙ:kₙ) ↦ τ ∈ 〚Ξ〛Mod | |
| 'synonym' S (α₁:k₁) … (αₙ:kₙ) ↦ τ ∈ 〚Ξ〛Mod |
cocreature
force-pushed
the
lf-synonym-docs
branch
from
166c340 to
dfc3adf
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtags, if appropriateNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.