Make Template ID optional in exercise; exercise by key #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced that is a good idea. What's the rationale for doing it? |
|
@hurryabit This refers only to the HTTP JSON API; contract ID is sufficient to disambiguate. As a rule we don't require anything we can derive in the HTTP JSON API. |
S11001001
modified the milestones:
HTTP JSON API First Version,
HTTP JSON API Maintenance
|
Can we close this? |
@hurryabit we want to finish it, but it is not our top priority. Current priorities (sorted): |
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2019
* Lookup by Contract ID and Contract Key is WIP * factor out "contract ID or key" JSON decoding - adapted from fc13225 (#2695) * Resolving conflicts * Resolving conflicts * Lookup by contract ID works * Testing new contract created by IOU_Transfer can be looked up * error if key and contractId specified for lookup at the same time * Lookup by contract key test * Lookup docs * re-format with `./fmt.sh` * minor cleanup CHANGELOG_BEGIN - [JSON API - Experimental] Fix and document ``/contracts/lookup`` endpoint. See #3755. CHANGELOG_END
|
Obsoleted by #4049. |
stefanobaghino-da
added
component/json-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exercise endpoint in HTTP JSON API currently requires a template ID, even when a contract ID is provided. In general for contract reference we want to support two forms:
We should support this for exercise as well as lookup (which already supports it).
Structurally dependent on #3755.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.