update copyright notices #2499
update copyright notices #2499
Conversation
garyverhaegen-da
requested review from
bame-da,
gerolf-da,
hurryabit,
leo-da,
nickchapman-da,
rautenrieth-da,
remyhaemmerle-da,
S11001001 and
stefanobaghino-da
as code owners
garyverhaegen-da
force-pushed
the
copyright
branch
2 times, most recently
from
176607b to
f300fb2
Compare
|
Once #2502 is merged I'll rerun the script on then-master an update this PR with the result. Changed lines should be added == removed. |
garyverhaegen-da
force-pushed
the
copyright
branch
from
f300fb2 to
3813c2a
Compare
There was a problem hiding this comment.
The files in ledger/sandbox/src/main/resources/db/migration/* are immutable, their hash is used in the database migration.
If changing them is absolutely necessary, we will have to find a way to help users with persistent sandbox databases deal with the resulting breakage (e.g., https://flywaydb.org/documentation/command/repair.html).
|
Building on top of @rautenrieth-da's review, I would suggest to either:
The first approach could be viable as applied exclusively to existing migration scripts, since they cannot be changed. |
garyverhaegen-da
force-pushed
the
copyright
branch
from
3813c2a to
96f5f15
Compare
The goal of the new header is to accommodate external contributions (as, given our CLA, they retain copyright to their contribution). Therefore, if those files are immutable and have been written entirely by DA employees so far, there is no need to update them. I have rebased this PR on top of #2514, so migration files should now be unchanged by this. Could you please update your review to match the new state of this PR? |
Copyright is complicated and I don't understand it. The legal team tells me this is better.