Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clenup LF versions java codegen test #18689

Merged
merged 1 commit into from
Mar 8, 2024
Merged

clenup LF versions java codegen test #18689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
clean LF versions in java codegen test
  • Loading branch information
@remyhaemmerle-da
remyhaemmerle-da committed Mar 8, 2024
commit 30910b4d9a07a18d66f6e550c704a4b8bde06ca3
18 changes: 0 additions & 18 deletions language-support/java/codegen/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,6 @@ java_library(

module_prefix_test = "src/it/java/com/daml/ModulePrefixes.java"

contract_keys_test = "src/it/java/com/daml/ContractKeysTest.java"

java_test(
name = "integration-tests-module-prefixes",
srcs = [module_prefix_test],
Expand All @@ -330,21 +328,6 @@ java_test(
],
)

java_test(
name = "integration-tests-contract-keys",
srcs = [contract_keys_test],
test_class = "com.daml.ContractKeysTest",
deps = [
":integration-tests-model-2.dev",
"//canton:bindings-java",
"@maven//:com_google_protobuf_protobuf_java",
"@maven//:org_junit_jupiter_junit_jupiter_api",
"@maven//:org_junit_jupiter_junit_jupiter_engine",
"@maven//:org_junit_platform_junit_platform_commons",
"@maven//:org_junit_platform_junit_platform_runner",
],
)
Comment on lines -333 to -346
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to create a special case for contract key, just need to make it a 2.dev test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right! I did this change mechanically without looking at the larger picture.


[
[
#
Expand All @@ -368,7 +351,6 @@ java_test(
],
exclude = [
module_prefix_test,
contract_keys_test,
],
),
test_class = "com.daml.AllTests",
Expand Down
19 changes: 0 additions & 19 deletions language-support/java/codegen/src/it/daml/Lib_1_6.daml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions language-support/java/codegen/src/it/daml/Lib_1_7.daml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions language-support/java/codegen/src/it/daml/Lib_1_8.daml
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions language-support/java/codegen/src/it/daml/Lib_1_dev.daml
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions ...rt/java/codegen/src/it/daml/Lib_1_12.daml → ...ort/java/codegen/src/it/daml/Lib_2_1.daml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
-- SPDX-License-Identifier: Apache-2.0


module Lib_1_12 where
module Lib_2_1 where

import Tests.Template1()
import Tests.Template2()
Expand All @@ -16,6 +16,5 @@ import Tests.Import()
import Tests.Escape()
import Tests.TextMapTest()
import Tests.GenMapTest()
import Tests.ContractKeys()
import Tests.ParametersOrder()
import Tests.UpgradeTest()
2 changes: 1 addition & 1 deletion ...rt/java/codegen/src/it/daml/Lib_1_11.daml → ...t/java/codegen/src/it/daml/Lib_2_dev.daml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
-- SPDX-License-Identifier: Apache-2.0


module Lib_1_11 where
module Lib_2_dev where

import Tests.Template1()
import Tests.Template2()
Expand Down
15 changes: 0 additions & 15 deletions language-support/java/codegen/src/it/java-1.11/com/daml/AllTests.java
View file
Open in desktop

This file was deleted.

Loading
Loading