-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the hie-bios commit SHA #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It would be great if you could also update the hash used by Bazel so the two stay in sync
Line 551 in e63b012
"9f9fe00591c429c410475349560252ca7e622f1b", |
@moritzkiefer-da looks like this induces some required source code changes. Let's pick it up Monday. |
The last commit adds some tutorial documentation on Emacs integration. |
@shayne-fletcher-da I’ve pushed a fix for the errors you got. |
@@ -0,0 +1,50 @@ | |||
# How to get `hie-core` working in Emacs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just fling this as a section in the normal readme for hie-core. I wouldn't have thought of hunting for an emacs specific one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy that @neil-da. I'll take care of it Monday. Initial doc. was just to get something going. I'll make it nice and integrate.
@moritzkiefer-da , 🎸 ! |
* Update the hie-bios commit SHA * Also update the SHA in our bazel WORKSPACE * Update the hash too * Tutorial for Emacs integration * Update hie-bios patch
Might not have been necessary in the end to get hie-core working in emacs but as @cocreature says, there have been many fixes so this is probably a good idea anyway.