Remove compiler support for controller..can choice syntax
#17362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2023
Merged
akrmn
requested review from
hrischuk-da,
a team,
filmackay,
basvangijzel-DA,
remyhaemmerle-da,
dylant-da,
samuel-williams-da and
paulbrauner-da
as code owners
akrmn
force-pushed
the
akrmn/no-controller-can
branch
from
2c6534d to
0f4d688
Compare
thanks for the reminder, it's done now :) |
akrmn
commented
Sep 5, 2023
| Note that, as a consequence, the warning flags `-Wcontroller-can` and | ||
| `-Wnocontroller-can` are not accepted anymore. | ||
|
|
||
| See [Deprecation of `controller`-first syntax: Migrating](https://docs.daml.com/2.7.0/daml/reference/choices.html#migrating) |
There was a problem hiding this comment.
intentionally pointing to the 2.seven.0 docs, I don't think we want to keep the migration guide in the 2.8.0 docs; if we do, we'd just be pushing the deprecation down the line
carrielaben-da
approved these changes
Sep 5, 2023
akrmn
force-pushed
the
akrmn/no-controller-can
branch
3 times, most recently
from
a75a137 to
0094243
Compare
Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>
akrmn
force-pushed
the
akrmn/no-controller-can
branch
from
0094243 to
fb01ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17361
Daml PR: #17362
DA-GHC PR: digital-asset/ghc#171
docs.daml.com PR: digital-asset/docs.daml.com#453