Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues with the reference daml-on-x implementation #1613

Merged
4 commits merged into from
Jun 13, 2019
Merged

Fix various issues with the reference daml-on-x implementation #1613

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c252eb
Fix various issues with the reference daml-on-x implementation
Jun 12, 2019
7344472
fix transaction validation which started reporting different error type
mziolekda Jun 13, 2019
fa4c75e
fix transaction fetching tests on sandbox that assumed that transacti…
mziolekda Jun 13, 2019
3d8f6d4
return NOT_FOUND in all places where a non-existing transaction id or…
mziolekda Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix transaction validation which started reporting different error type
  • Loading branch information
@mziolekda
mziolekda committed Jun 13, 2019
commit 73444723d02b7090be6e109a3022a46635759755
1 change: 1 addition & 0 deletions ...ain/scala/com/digitalasset/ledger/api/validation/TransactionServiceRequestValidator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ class TransactionServiceRequestValidator(
req: GetTransactionByIdRequest): Result[transaction.GetTransactionByIdRequest] = {
for {
ledgerId <- matchId(LedgerId(req.ledgerId))
_ <- requireNonEmptyString(req.transactionId, "transaction_id")
trId <- requireLedgerString(req.transactionId)
_ <- requireNonEmpty(req.requestingParties, "requesting_parties")
parties <- partyValidator.requireKnownParties(req.requestingParties)
Expand Down