Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tf #13028

Merged
merged 13 commits into from
Feb 22, 2022
Merged

Fix tf #13028

merged 13 commits into from
Feb 22, 2022

Conversation

garyverhaegen-da
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da commented Feb 22, 2022 •
edited by ray-roestenburg-da
Loading

Goals:

Details in commits.

CHANGELOG_BEGIN
CHANGELOG_END

(We can't do partial updates in TF so can't merge #12996 and 12997 separately.)

@garyverhaegen-da
fix tf
7a61fce 
Goals:

- Reflect manual changes from #12996 in Terraform.
- Reflect manual changes from #12997 in Terraform.
- Update plugins to wirk with #12929.
- Keep running services working through the changes.

Details in commits.

CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da
bump plugins (no deploy)
e53c245
@garyverhaegen-da
new nix, new terraform, new formatting
a7adf7e
@garyverhaegen-da
reflect (consequential) manual changes (deployed)
30f304f
@garyverhaegen-da
steal from #12996: fix inactive ci-u1 (deployed)
94129aa
@garyverhaegen-da
steal from #12997: fix inactive hoogle-green (deployed)
61c09c2
@garyverhaegen-da
enable ci-u1 & hoogle-green (deployed)
89482c3
This was referenced Feb 22, 2022
Closed
Closed
@cocreature
Copy link
Contributor

Did you mix up PR numbers? I don’t understand how the auth middleware affects tf.

@garyverhaegen-da
Copy link
Contributor Author

Did you mix up PR numbers? I don’t understand how the auth middleware affects tf.

Indeed I did, that's supposed to be #12926.

cocreature
cocreature approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@garyverhaegen-da garyverhaegen-da enabled auto-merge (squash) February 22, 2022 17:15
@garyverhaegen-da garyverhaegen-da merged commit 583cad5 into main Feb 22, 2022
@garyverhaegen-da garyverhaegen-da deleted the fix-tf branch February 22, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

@cocreature cocreature cocreature approved these changes

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

@adriaanm-da adriaanm-da Awaiting requested review from adriaanm-da

Assignees
No one assigned
Labels
Standard-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyverhaegen-da @cocreature @ray-roestenburg-da