Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Haskell tests to Sandbox on X #12761

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Migrate Haskell tests to Sandbox on X #12761

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed63075
Migrate Haskell tests to Sandbox on X
cocreature Feb 4, 2022
951c9b0
.
cocreature Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
. 
changelog_begin
changelog_end
  • Loading branch information
@cocreature
cocreature committed Feb 7, 2022
commit 951c9b06c9a9b0bea3f9ab43ca544cd8802db413
2 changes: 1 addition & 1 deletion language-support/hs/bindings/test/DA/Ledger/Tests.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ tGetLedgerConfiguration withSandbox = testCase "tGetLedgerConfiguration" $ run w
xs <- getLedgerConfiguration lid
Just (Right config) <- liftIO $ timeout 1 (takeStream xs)
let expected = LedgerConfiguration {
maxDeduplicationTime = Duration {durationSeconds = 86400, durationNanos = 0}}
maxDeduplicationTime = Duration {durationSeconds = 1800, durationNanos = 0}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tudor-da I assume this is expected?

Copy link
Contributor

@tudor-da tudor-da Feb 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is due to an optimization for Sandbox-on-X. For simplicity, deduplication is done in-memory for Sandbox-on-X. For that reason (i.e to avoid OOMs), the default maxDeduplicationTime is 30 minutes with the maximum configurable to one hour.

liftIO $ assertEqual "config" expected config

tUploadDarFileBad :: SandboxTest
Expand Down