Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tear down daml services gracefully #12591

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Tear down daml services gracefully #12591

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8145ce
Tear down daml services gracefully
cocreature Jan 26, 2022
38597f1
typing is hard
cocreature Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
typing is hard 
changelog_begin
changelog_end
  • Loading branch information
@cocreature
cocreature committed Jan 26, 2022
commit 38597f1ed65688fac3ce178c69462f6aa20c3798
4 changes: 2 additions & 2 deletions daml-assistant/integration-tests/src/DA/Daml/Assistant/IntegrationTests.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ withDamlServiceIn path command args act = withDevNull $ \devNull -> do
-- We tear things down gracefully instead of killing
-- the process group so that waiting for the parent process
-- ensures that all child processes are all dead too.
-- Gonig via closing stdin works on Windows whereas tearing things
-- down gracefully
-- Going via closing stdin works on Windows whereas tearing things
-- down gracefully via SIGTERM isn’t as much of a thing so we use the former.
_ <- waitForProcess ph
pure r

Expand Down