Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split-release: Canton dependencies to public GCS #12552

Merged
merged 1 commit into from
Jan 24, 2022
Merged

split-release: Canton dependencies to public GCS #12552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,16 @@ jobs:
eval "$(./dev-env/bin/dade-assist)"
mkdir -p $(Build.StagingDirectory)/split-release
./ci/assembly-split-release-artifacts.sh $(release_tag) $(Build.StagingDirectory)/release-artifacts $(Build.StagingDirectory)/split-release
- bash: |
set -euo pipefail
source $(bash-lib)
cd $(Build.StagingDirectory)/split-release/split-release
for f in "damlc-*" daml-libs/daml-script; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for f in "damlc-*" daml-libs/daml-script; do
for f in "damlc-*" daml-libs/daml-script daml-libs/daml-trigger; do

I‘m also not sure listing those in here is a good idea. The list of libraries seems like the type of thing that is going to change across releases and blow up once we do releases for an older branch. Should we move this to a separate bash script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't imagine that blowing up unless we delete daml-script. Library dependencies seem largely additive, so worst case we push more than needed for a patch release.

@oliverse-da told me they're not using daml-trigger. Note that this is intended as a convenience for local development; all the artifacts are still on Artifactory and I would still expect CI to get them all from there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I’m worried about is that we add a new lib in the future that we want to use in Canton and then it blows up on older releases. But if you’re comfortable addressing it at that point, I’m fine with it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is likely enough to be worth a separate file here, partly because we're copying from a folder that is itself already created by a separate file, so we have an easy way to fix it should it happen.

gcs "$GCRED" cp -r "$f" "gs://daml-binaries/split-releases/$(release_tag)/"
done
name: gcs_for_canton
env:
GCRED: $(GOOGLE_APPLICATION_CREDENTIALS_CONTENT)
- bash: |
set -euo pipefail
./ci/publish-artifactory.sh $(Build.StagingDirectory) $(release_tag) split
Expand Down