Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell users to use --install-assistant=yes #12507

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Tell users to use --install-assistant=yes #12507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64efaf7
Tell users to use --install-assistant=yes
sofiafaro-da Jan 20, 2022
1c2f6a6
modernise error message somewhat
sofiafaro-da Jan 20, 2022
26bf749
add 'current'
sofiafaro-da Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ On Windows:
bazel build //release:sdk-release-tarball
tar -vxf .\bazel-bin\release\sdk-release-tarball-ce.tar.gz
cd sdk-*
daml\daml.exe install . --activate
daml\daml.exe install . --install-assistant=yes
```

That should tell you what to put in the path, something along the lines of `C:\Users\admin\AppData\Roaming\daml\bin`.
Expand Down
10 changes: 5 additions & 5 deletions daml-assistant/src/DA/Daml/Assistant/Install.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,12 +503,12 @@ uninstallVersion Env{..} sdkVersion = wrapErr "Uninstalling SDK version." $ do
if exists then do
when (Just (DamlAssistantSdkVersion sdkVersion) == envDamlAssistantSdkVersion) $ do
hPutStr stderr . unlines $
[ "Cannot uninstall currently activated SDK version."
, "Please activate a different SDK version and try again."
, "To activate a different version, run:"
[ "Cannot uninstall SDK version of current daml assistant."
, "Please switch to a different version of daml assistant and try again."
, "To switch to a different version of daml assistant, use:"
, ""
, " daml install VERSION --activate"
] -- TODO (FAFM): suggest a version that will work.
, " daml install VERSION --install-assistant=yes"
] -- TODO: suggest a version that will work.
exitFailure

requiredIO "Failed to set write permission for SDK files to remove." $ do
Expand Down
2 changes: 1 addition & 1 deletion language-support/hs/bindings/examples/nim/demo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Notes on the format of this file:

$ cd daml
$ bazel build language-support/hs/bindings/examples/nim/...
$ daml install latest --activate
$ daml install latest --install-assistant=yes

## 1. Look at [Nim.daml](https://github.com/digital-asset/daml/blob/main/language-support/hs/bindings/examples/nim/daml/Nim.daml)

Expand Down