Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid stale DAML_SDK_VERSION_LATEST in assistant #12493

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Avoid stale DAML_SDK_VERSION_LATEST in assistant #12493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63472c5
Avoid stale "latest SDK version" in assistant
sofiafaro-da Jan 19, 2022
a1cbba3
treat all values as stale with update-check: never
sofiafaro-da Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
treat all values as stale with update-check: never
  • Loading branch information
@sofiafaro-da
sofiafaro-da committed Jan 20, 2022
commit a1cbba388a47c848baa9abf4d6cf61e511e0820c
2 changes: 1 addition & 1 deletion daml-assistant/src/DA/Daml/Assistant/Cache.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ cacheAvailableSdkVersions damlPath cachePath getVersions = do
defaultUpdateCheck = UpdateCheckEvery (CacheTimeout 86400)
case fromMaybe defaultUpdateCheck updateCheckM of
UpdateCheckNever -> do
valueAgeM <- loadFromCacheWith cachePath versionsKey (CacheTimeout 86400) deserializeVersions
valueAgeM <- loadFromCacheWith cachePath versionsKey (CacheTimeout 0) deserializeVersions
pure $ fromMaybe ([], Stale) valueAgeM

UpdateCheckEvery timeout ->
Expand Down