Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPP-417][Self-service error codes][Docs] Add more complete information for forking gRPC status codes. #11739

Merged
merged 7 commits into from
Nov 18, 2021
Merged

[DPP-417][Self-service error codes][Docs] Add more complete information for forking gRPC status codes. #11739

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f658ad9
[DPP-417][Self-service error codes][Docs] Add more complete informati…
pbatko-da Nov 17, 2021
0801655
Other impr
pbatko-da Nov 17, 2021
b69147a
Fix Scala 2 12
pbatko-da Nov 17, 2021
674d345
Add missing remarks
pbatko-da Nov 17, 2021
51ceee5
MZ review
pbatko-da Nov 18, 2021
60404d0
Merge branch 'main' into pbatko/error-codes/dpp-417-docs-for-forking-…
pbatko-da Nov 18, 2021
712c6da
Sync with main
pbatko-da Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Scala 2 12
  • Loading branch information
@pbatko-da
pbatko-da committed Nov 17, 2021
commit b69147aa507e5fc56d99d13f130923776a309c0b
4 changes: 2 additions & 2 deletions ...i/src/docs/scala/com/daml/platform/docs/SelfServiceErrorCodes_MigrationGuideGen_App.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ object SelfServiceErrorCodes_MigrationGuideGen_App {
if (!affectedMap.contains(key)) {
affectedMap.put(key, new ArrayBuffer[Array[String]])
}
affectedMap.apply(key).addOne(line)
affectedMap.apply(key) += (line)
}

// Add unchanged codes if the there is a change for this (endpoint, old_code) pair
Expand All @@ -205,7 +205,7 @@ object SelfServiceErrorCodes_MigrationGuideGen_App {
val key = EndpointWithGrpcCode(line(0), line(1))

if (affectedMap.contains(key)) {
affectedMap.apply(key).addOne(line)
affectedMap.apply(key) += (line)
}
}

Expand Down