Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contract_tpid_fkey-related race condition #11330

Merged
merged 8 commits into from
Oct 22, 2021
Merged

fix contract_tpid_fkey-related race condition #11330

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d858aa4
trying to reliably reproduce the template ID constraint error
S11001001 Oct 20, 2021
4633c31
tentative fix for template ID constraint error
S11001001 Oct 20, 2021
a725fc4
sequential simulation
S11001001 Oct 21, 2021
63c3820
successfully reproduce the error pre-4633c3137a
S11001001 Oct 21, 2021
dbd379b
also reproduced the error pre-4633c3137a on Oracle
S11001001 Oct 21, 2021
fae8ad2
add changelog
S11001001 Oct 21, 2021
b2aab2c
clean up some now-unneeded printlns
S11001001 Oct 21, 2021
c5403f7
Merge commit 'e6da1f7b52ea680ea152871728f5210ae03337c2' into invalid-…
S11001001 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tentative fix for template ID constraint error
  • Loading branch information
@S11001001
S11001001 committed Oct 20, 2021
commit 4633c3137a78eb5629654714e2b8ee00dd838466
5 changes: 4 additions & 1 deletion ledger-service/db-backend/src/main/scala/com/digitalasset/http/dbbackend/Queries.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ sealed abstract class Queries(tablePrefix: String, tpIdCacheMaxEntries: Long)(im
Applicative[ConnectionIO].pure(tpId)
}
.getOrElse {
surrogateTemplateIdFromDb(packageId, moduleName, entityName).map { tpId =>
for {
tpId <- surrogateTemplateIdFromDb(packageId, moduleName, entityName)
_ <- connection.commit
} yield {
surrogateTpIdCache.setCacheValue(packageId, moduleName, entityName, tpId)
tpId
}
Expand Down