Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Windows errors #6262

Closed
garyverhaegen-da opened this issue Jun 8, 2020 · 28 comments
Closed

Tracking Windows errors #6262

garyverhaegen-da opened this issue Jun 8, 2020 · 28 comments

Comments

@garyverhaegen-da
Copy link
Contributor

We have seen many errors on Windows recently. This issue is trying to keep track of them, so we can have a better view on what kinds of issues we are seeing and how frequent they are, in the hope that this will help us formulate concrete plans to solve them.

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Jun 8, 2020

output was not created

Error message:

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:354:1: output 'compiler/damlc/tests/repl-functests.exe' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:354:1: not all outputs were created or valid

Affected commits:

921266a [log]
2a4e9dc [log]

Attempted resolution:

1 Clearing the cache through a separate PR
2. After 1 didn’t help, switch to a completely different cache in #6265. Issue in switching to a new cache fixed in #6270

Notes

Seems to be reproducible and affects all builds.

Did cleaning the cache fix the issue?

1 seems to have worked for some PRs but not for all of them unclear why.
2 seems to work properly so far.

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Jun 8, 2020

undeclared inclusions

Error message:

ERROR: C:/users/u/_bazel_u/igiwx5st/external/bazel_tools/tools/cpp/runfiles/BUILD:3:1: undeclared inclusion(s) in rule '@bazel_tools//tools/cpp/runfiles:runfiles':
this rule is missing dependency declarations for the following files included by 'external/bazel_tools/tools/cpp/runfiles/runfiles.cc':

Affected commits:

b9fbba7 [build step] [test step] [exec log too large, 1.2GB]

Note: b9fbba7 succeeded at the exact same build on the previous day: [build step], [test step], [Bazel execution log (zip)].

Notes

We’ve seen this issue numerous times before and believe it is due to working directories leaking into the cache.

Did cleaning the cache fix the issue?

Fix 2 from the previous issue also seems to workaround this one so far.

@cocreature
Copy link
Contributor

cocreature commented Jun 9, 2020

undeclared inclusions

Same error as before but this is after we reset the cache.

Resolution

Switch to modifying the cache URL instead of relying on platform_suffix. See #6273. Also required commiting clean --expunge and manually resetting nodes.

@cocreature
Copy link
Contributor

output was not created

error message

ERROR: D:/a/2/s/compiler/scenario-service/protos/BUILD.bazel:67:1: output 'compiler/scenario-service/protos/_obj/scenario_service_haskell_proto/ScenarioService.o' was not created

Affected commits

https://dev.azure.com/digitalasset/daml/_build/results?buildId=45869&view=results

Resolution

Rerun succeded but on a different node. Builds on the same node failed.
Bump Windows cache and take out the node.

Notes

Caches are separated by working directories. This only seems to have affected the node that ran the daily compat check which runs in a different working directory.

@aherrmann-da
Copy link
Contributor

aherrmann-da commented Jun 12, 2020

output was not created

error message

ERROR: D:/a/1/s/daml-assistant/integration-tests/BUILD.bazel:162:1: output 'daml-assistant/integration-tests/create-daml-app-tests.exe' was not created
ERROR: D:/a/1/s/daml-assistant/integration-tests/BUILD.bazel:162:1: not all outputs were created or valid

Affected commits

f2cd820 build
#6320 build
969b0ff build

Resolution

Bump Windows cache and clean --expunge.

@cocreature
Copy link
Contributor

cocreature commented Jun 17, 2020

Output was not created

error message

ERROR: D:/a/1/s/compiler/damlc/daml-package-config/BUILD.bazel:9:1: output 'compiler/damlc/daml-package-config/_obj/daml-package-config/DA/Daml/Package/Config.o' was not created

Affected commits

#6375

Resolution

We’ve tried selectively cleaning the cache via bazel clean --expunge and building without fetching from the cache. That did make the PR pass and we merged it but then it failed on master. The succeeding and the failing PR on master ran on a different node. We’ve lost the node of the failing PR.

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Jun 17, 2020

Output was not created

error message

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:549:1: output 'compiler/damlc/tests/_obj/unstable-types/DA/Test/UnstableTypes.o' was not created
ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:549:1: output 'compiler/damlc/tests/_iface/unstable-types/DA/Test/UnstableTypes.hi' was not created
ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:549:1: not all outputs were created or valid

Affected commits

#6381

Resolution

Selectively cleaning the cache did not seem to help this time, so we instead bumped the cache counter (#6383), which worked.

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Jul 3, 2020

Output was not created

error message

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/PrettyScenario.o' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient.o' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient/LowLevel.o' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/PrettyScenario.hi' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient.hi' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient/LowLevel.hi' was not created
ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:1: not all outputs were created or valid
ERROR: D:/a/1/s/compiler/damlc/daml-opts/BUILD.bazel:38:1 not all outputs were created or valid

Affected commits

3e55fda: log

Resolution

#6604

@cocreature
Copy link
Contributor

Output was not created

Error message

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Alpha.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Base.o' was not created
ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/FreeVars.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Numeric.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Optics.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Pretty.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Recursive.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Subst.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: output 'compiler/daml-lf-ast/_obj/daml-lf-ast/DA/Daml/LF/Ast/Type.o' was not created

ERROR: D:/a/1/s/compiler/daml-lf-ast/BUILD.bazel:6:1: not all outputs were created or valid

ERROR: D:/a/1/s/compiler/damlc/BUILD.bazel:10:1 not all outputs were created or valid

Affected commits

c203cd3 log

Resolution

pending

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Aug 5, 2020

not all outputs were created or valid

Happened on the compat build for a 1.5-snapshot update PR. Machine was vsts-win-q1s0. Full log.

Also happened on #6884 on vsts-win-pn4d. Full log.

Also happened (twice) on vsts-win-cw68. Log for #7007; log for #7011.

Resolution

Pending: trying to take out just that node for now, but may need to escalate to cache bumping.

@cocreature
Copy link
Contributor

cocreature commented Aug 6, 2020

Output was not created

Happened on #7039

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/PrettyScenario.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient/LowLevel.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/PrettyScenario.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient/LowLevel.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: not all outputs were created or valid

ERROR: D:/a/2/s/compiler/damlc/daml-opts/BUILD.bazel:38:19 not all outputs were created or valid
Resolution

Took out the affected node.

@cocreature
Copy link
Contributor

Output was not created

Happened on rerun of #7007

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/PrettyScenario.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient/LowLevel.o' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/PrettyScenario.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient/LowLevel.hi' was not created

ERROR: D:/a/2/s/compiler/scenario-service/client/BUILD.bazel:6:19: not all outputs were created or valid

run in D:/a/2/s

Resolution

Going to try resetting the cache, this is too annoying.

@cocreature
Copy link
Contributor

Output was not created

ab8b418

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/PrettyScenario.o' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient.o' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/_obj/client/DA/Daml/LF/ScenarioServiceClient/LowLevel.o' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/PrettyScenario.hi' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient.hi' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: output 'compiler/scenario-service/client/compilerZSscenario-serviceZSclientZSclient/_iface/DA/Daml/LF/ScenarioServiceClient/LowLevel.hi' was not created

ERROR: D:/a/1/s/compiler/scenario-service/client/BUILD.bazel:6:19: not all outputs were created or valid

Resolution

Disabled machine, let’s see if it helps.

@garyverhaegen-da
Copy link
Contributor Author

garyverhaegen-da commented Aug 20, 2020

Output was not created

Windows compat job.

INFO: From Executing genrule //compiler/damlc:daml-prim-json-docs:

ERROR: D:/a/1/s/compiler/damlc/BUILD.bazel:78:12: output 'compiler/damlc/damlc-dist.tar.gz' was not created

ERROR: D:/a/1/s/compiler/damlc/BUILD.bazel:78:12: not all outputs were created or valid

Killed the machine (PN4D). 🤞

@garyverhaegen-da
Copy link
Contributor Author

Output not created

This time in the Windows job.

ERROR: D:/a/1/s/compiler/damlc/BUILD.bazel:78:12: output 'compiler/damlc/damlc-dist.tar.gz' was not created

ERROR: D:/a/1/s/compiler/damlc/BUILD.bazel:78:12: not all outputs were created or valid

Killed the machine (Q1S0).

@garyverhaegen-da
Copy link
Contributor Author

Output not created

Same... Machine CW68 this time. Also killed.

@garyverhaegen-da
Copy link
Contributor Author

Note: it looks like rebasing made the above disappear. The PR on which those appeared (#7146) changes the stdlib so triggers targets we don't often rebuild.

@garyverhaegen-da
Copy link
Contributor Author

Output not created, master

On commit c997f5d, node PN4D

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: output 'compiler/damlc/tests/_obj/integration-v18/DA/Test/DamlcIntegrationMain.o' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: output 'compiler/damlc/tests/_iface/integration-v18/DA/Test/DamlcIntegrationMain.hi' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: not all outputs were created or valid

Node killed.

@garyverhaegen-da
Copy link
Contributor Author

Output not created, master

On commit f54e193, node CW68.

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: output 'compiler/damlc/tests/_obj/integration-v18/DA/Test/DamlcIntegrationMain.o' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: output 'compiler/damlc/tests/_iface/integration-v18/DA/Test/DamlcIntegrationMain.hi' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: not all outputs were created or valid

Node killed.

@garyverhaegen-da
Copy link
Contributor Author

Above kept happening so we've decided to bump the cache (#7212).

@garyverhaegen-da
Copy link
Contributor Author

Output not created, #7385

Machine CW68:


[2,824 / 2,836] checking cached actions

ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: output 'daml-assistant/_obj/daml/DA/Daml/Assistant.o' was not created

ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: output 'daml-assistant/_iface/daml/DA/Daml/Assistant.hi' was not created

ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: not all outputs were created or valid

INFO: Elapsed time: 96.348s, Critical Path: 3.87s

INFO: 1 process: 1 local.

FAILED: Build did NOT complete successfully

Disabled the machine for now.

@garyverhaegen-da
Copy link
Contributor Author

Output not created, master

This is #7385 again, but this time after merge (d966178). I have disabled the machine (PN4D) and will try rerunning.

@cocreature
Copy link
Contributor

cocreature commented Sep 15, 2020

Output not created, master

Created C:/users/u/_bazel_u/vvgx3zjt/execroot/com_github_digital_asset_daml/bazel-out/x64_windows-opt/bin/triggers/daml/daml-trigger-1.8.dar
ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: output 'daml-assistant/_obj/daml/DA/Daml/Assistant.o' was not created

ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: output 'daml-assistant/_iface/daml/DA/Daml/Assistant.hi' was not created

ERROR: D:/a/2/s/daml-assistant/BUILD.bazel:75:18: not all outputs were created or valid

INFO: Elapsed time: 541.649s, Critical Path: 68.92s

This is on /d/a/2/s so it might just be that we have to reset the 2 cache (which the way we currently handle it also means resetting the 1 cache`). For now, I’ve disabled the node.

@ghost
Copy link

ghost commented Sep 29, 2020

Output not created, #7517

On commit 1849b76 (#7517).

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: output 'compiler/damlc/tests/integration-v17.exe' was not created

ERROR: D:/a/1/s/compiler/damlc/tests/BUILD.bazel:156:20: not all outputs were created or valid

Build log

@cocreature
Copy link
Contributor

cocreature commented Sep 30, 2020

Output not created, #7542

ERROR: D:/a/1/s/ci/cron/BUILD.bazel:6:18: output 'ci/cron/_obj/cron/Main.o' was not created

ERROR: D:/a/1/s/ci/cron/BUILD.bazel:6:18: output 'ci/cron/_iface/cron/Main.hi' was not created

ERROR: D:/a/1/s/ci/cron/BUILD.bazel:6:18: not all outputs were created or valid

Interestingly this is the one that was modified in this PR.

I’ve taken out the node for now, let’s see if that helps.

Edit: It didn’t, took out a second node.
Edit2: 💩 3rd node failed as well, trying a build without caching now.
Edit3: Rebuild without cache didn’t seem to help either (it worked for one build but then the next build on another node failed). I ended up solving it with a dummy whitespace change 🤦

@garyverhaegen-da
Copy link
Contributor Author

Output not created, all over the place

Loads of this one today. We decided to go for a more targeted approach for the fix and are currently trying to only force a rebuild of the one file that fails: #7613.

@ghost
Copy link

ghost commented Oct 21, 2020

Output not created, #7767.

On commit deb1c58.

Full log.

ERROR: D:/a/2/s/compiler/daml-lf-reader/BUILD.bazel:6:19: output 'compiler/daml-lf-reader/_obj/daml-lf-reader/DA/Daml/LF/Reader.o' was not created

ERROR: D:/a/2/s/compiler/daml-lf-reader/BUILD.bazel:6:19: output 'compiler/daml-lf-reader/compilerZSdaml-lf-readerZSdaml-lf-reader/_iface/DA/Daml/LF/Reader.hi' was not created

ERROR: D:/a/2/s/compiler/daml-lf-reader/BUILD.bazel:6:19: not all outputs were created or valid

@cocreature
Copy link
Contributor

Closing since it seems to have done the job. We now have a workaround for the caching issue in place via #8668. Note that this does not stop the error from happening but it stops it from breaking the cache so we can simply take out the node and move on. We could automate that part as well but atm it seems to happen once a week or so at most so not that urgent of an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants