Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add byId to template and interface-marker classes #15603

Open
3 tasks
S11001001 opened this issue Nov 16, 2022 · 0 comments
Open
3 tasks

add byId to template and interface-marker classes #15603

S11001001 opened this issue Nov 16, 2022 · 0 comments
Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

This is a conversion static method in both

  • template class and
  • interface marker class

CT, signed

  public static ContractId byId(codegen.ContractId<CT> genericForm)

As this method replaces ContractId.fromContractId, which isn't present for interface ContractId classes, that

  • generated fromContractId should be deprecated, with a note pointing to the new byId method.

This idea came up in #14420 by @StephenOTT, for its symmetry with byKey. We can do this to fix the missing fromContractId with a more easily-accessible version, while also providing a prerequisite to getting rid of the ContractId class entirely as suggested by @cocreature, should we decide to do that, in the form of a method that would give generic-ContractId users access to the Exercises.

@S11001001 S11001001 added component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components. labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

No branches or pull requests

1 participant