Skip to content

Commit

Permalink
work around Azure/GitHub disagreement
Browse files Browse the repository at this point in the history
Azure used to report the status of the entire build to GitHub, which we
use as the "required check" for PRs to be merged. Ir doesn't do that
anymore which means we can't merge anything. It's unclear whether or not
that is a deliberate change.

This attempts to work around that by creating an extra job that depends
on all the other, which GitHub could depend on.

CHANGELOG_BEGIN
CHANGELOG_END
  • Loading branch information
garyverhaegen-da committed Oct 23, 2020
1 parent 19a7f32 commit 981a41a
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -893,3 +893,31 @@ jobs:
else
echo "User $(user_id) did not opt in for notifications."
fi
# temporary (?) workaround for Azure not reporting global build status to GitHub anymore.
- job: finished
pool:
name: 'linux-pool'
demands: assignment -equals default
dependsOn:
- git_sha
- check_standard_change_label
- check_changelog_entry
- Linux
- macOS
- Windows
- compatibility_ts_libs
- compatibility_linux
- compatibility_macos
- compatibility_windows
- check_for_release
- check_perf_test
- release
- compat_versions_pr
- compat_versions_pr_trigger_daily
- write_ledger_dump
- collect_build_data
- notify_release_pr
- notify_user
steps:
bash: exit 0

0 comments on commit 981a41a

Please sign in to comment.