Ensure that -Werror converts parser warnings into errors

closes #11399 changelog_begin changelog_end
digital-asset · Nov 2, 2021 · 1804c9d · 1804c9d
1 parent 92495b0
commit 1804c9d
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/bazel-haskell-deps.bzl b/bazel-haskell-deps.bzl
@@ -17,8 +17,8 @@ load("@os_info//:os_info.bzl", "is_linux", "is_windows")
 load("@dadew//:dadew.bzl", "dadew_tool_home")
 load("@rules_haskell//haskell:cabal.bzl", "stack_snapshot")
 
-GHCIDE_REV = "2ba61893ea07df26dcacf165a79dd6d0381a3dc8"
-GHCIDE_SHA256 = "f3a2fb693d1e6d3beda542639de027a94ae3417fe483765510eceb2ad9ea2b29"
+GHCIDE_REV = "298307c7f7d0778d48a350a996f29ddebbe0f51d"
+GHCIDE_SHA256 = "aae5a14f94f4d2fc6a39f670f2bd9ddba38488adaa3c7e544b5abf54911afa63"
 JS_JQUERY_VERSION = "3.3.1"
 JS_DGTABLE_VERSION = "0.5.2"
 JS_FLOT_VERSION = "0.8.3"

diff --git a/compiler/damlc/tests/daml-test-files/ParserWerror.daml b/compiler/damlc/tests/daml-test-files/ParserWerror.daml
@@ -0,0 +1,11 @@
+-- Copyright (c) 2021, Digital Asset (Switzerland) GmbH and/or its affiliates.
+-- All rights reserved.
+
+{-# OPTIONS_GHC -Werror=missing-space-after-bang #-}
+
+-- @ERROR range=11:3-11:5; perhaps you want to add a space after the bang for clarity
+
+module ParserWerror where
+
+(!) : a -> a -> ()
+_ !_ = ()
diff --git a/compiler/damlc/tests/daml-test-files/ParserWno_error.daml b/compiler/damlc/tests/daml-test-files/ParserWno_error.daml
@@ -0,0 +1,11 @@
+-- Copyright (c) 2021, Digital Asset (Switzerland) GmbH and/or its affiliates.
+-- All rights reserved.
+
+{-# OPTIONS_GHC -Wno-error=missing-space-after-bang #-}
+
+-- @WARN range=11:3-11:5; perhaps you want to add a space after the bang for clarity
+
+module ParserWno_error where
+
+(!) : a -> a -> ()
+_ !_ = ()