-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 36: Implement entrypoint support #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote up some feedback before realizing you had this marked as a draft, whoops 😅 but I figured I might as well post it rather than discarding it. Feel free to ignore all my comments for a while if you're still working on this. And as always, all open to discussion.
ee0bcb2
to
18353c4
Compare
465311c
to
75b605d
Compare
I think it might be necessary to include "Closes #36" in the issue description to get the issue to be automatically closed when this is merged. (Putting it in a comment doesn't seem to be enough) |
75b605d
to
8c25833
Compare
Don't forget to resolve the merge conflicts. (I don't care whether you do it by rebasing or by merging Feel free to resolve comment threads that have been addressed or are otherwise no longer needed if you like, but I will also come back to this sometime in the next day or so and review all the comment threads, resolving as needed. Right now I only had time for a quick peek. (I'm supposed to be at work lol, but it's quiet at the moment) |
It didn't like the fact I was trying to save some copy-paste work.
We're now generating a section for this metadata. While we're here, add scripts and GUI scripts to that metadata. (Rebased on 8f007bc)
We're not calling or accessing any instance methods. While we're here, fill out the documentation a little more.
This is needed to be able to use a sequence of them to construct a `dict` using the `dict` constructor, as the latter does not like getting a sequence of `dict`s as input.
This may generate an empty `dict` if `setuptools` gives us an empty `list` as input, but 99% of the time we should be fine. We'll re-visit this if it becomes a problem later.
Use "doctests" style to document the function's behaviour, with more formal definitions below.
We don't actually need to expose them on the class itself since they reference none of the class instance fields. Probably makes more sense to make these discrete functions.
f6a99c5
to
1ffe28f
Compare
Since this isn't a public-facing API, it probably makes more sense to make this a doc test. It also helps document it.
The only time this is spelt entry-points, is in the TOML output. In documentation, it is "entry points" (space). In code, we'll use `entry_points` (underscore) -- _unless_ it's the TOML output.
a6645e3
to
13856b6
Compare
This implements the entry-point support. (Closes issue #36)