Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract HeadlessMode from diablo.h #7623

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Jan 8, 2025

Untangles some dependencies.
Many places that use HeadlessMode do not need all of diablo.h (e.g. assets, load_file)

Extracted from #7554.

@glebm glebm enabled auto-merge (rebase) January 8, 2025 07:42
@glebm
Copy link
Collaborator Author

glebm commented Jan 9, 2025

@AJenbo conflicts resolved

Untangles some dependencies.
Many places that use `HeadlessMode` do not need all of `diablo.h`.
@glebm
Copy link
Collaborator Author

glebm commented Jan 9, 2025

Rebased again

namespace devilution {

/**
* @brief Don't load UI or show Messageboxes or other user-interaction. Needed for unit tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And hopefully server mode one day :D

@glebm glebm merged commit a7651f1 into diasurgical:master Jan 9, 2025
23 checks passed
@glebm glebm deleted the headless-mode branch January 9, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants