Fixes for older VS versions, make sure dhewm3log.txt was created on Windows #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least VS2017 doesn't like the big string literal of proggyvector_font_base85.h (its limit is 64KB, Error C1091), so go back to using proggyvector_font.h (which contains an int32 array) for MSVC.. Keep the base85 version around for proper compilers, because (unlike the non-base85 version of the font) it works on Big Endian machines. It seems like VS2022, maybe even some point release of VS2019 removed this limitation (our CI build succeeds), but I couldn't find any details about that change.
If it (or Documents/My Games/dhewm3/) can't be created, show a windows MessageBox with an error message and exit. Would've made dhewm#544 easier to figure out
turol
reviewed
Jan 19, 2025
| } else { | ||
| char msg[2048]; | ||
| D3_snprintfC99( msg, sizeof(msg), "Failed to create '%s',\n error number is %d (%s)\nIs Documents/My Games/dhewm3/ write protected?", | ||
| stdoutPath, errno, strerror(errno) ); |
There was a problem hiding this comment.
Copy-paste error, wrong variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#544 has shown that dhewm3 will silently fail to start on Windows if dhewm3log.txt can't be created (for example because Documents/My Games/dhewm3/ can't be written to) and that debugging that is a major PITA.
Now a Windows MessageBox with an error message is shown.
Also fixed an issue that prevented VS2017 from compiling dhewm3 with ImGui enabled.